Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Presence): Remove redundant date parsing (v13) #8341

Merged
merged 1 commit into from Jul 23, 2022
Merged

refactor(Presence): Remove redundant date parsing (v13) #8341

merged 1 commit into from Jul 23, 2022

Conversation

Jiralite
Copy link
Member

Backports #8340 to version 13.

@vercel
Copy link

vercel bot commented Jul 23, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Jul 23, 2022 at 0:22AM (UTC)

@Jiralite Jiralite added this to the discord.js v13.10 milestone Jul 23, 2022
SpaceEEC
SpaceEEC approved these changes Jul 23, 2022
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't have returned NaN, but it's redundant anyway. 🤷

@Jiralite Jiralite changed the title fix(Presence): Do not return NaN for activity timestamp (v13) refactor(Presence): Remove redundant date parsing (v13) Jul 23, 2022
@Jiralite
Copy link
Member Author

Ah true. Edited the title.

@iCrawl iCrawl merged commit e95caa7 into discordjs:v13 Jul 23, 2022
@Jiralite Jiralite deleted the 13/presence-time branch July 23, 2022 18:22
@RedGuy12 RedGuy12 mentioned this pull request Oct 4, 2022
Closed
@RedGuy12 RedGuy12 mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js v13.9.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jiralite @kyranet @SpaceEEC @iCrawl