New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(GuildAuditLogsEntry): replace OverwriteType with AuditLogOptionsType #8345
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The types need to be updated in GuildAuditLogsEntryExtraField
:
discord.js/packages/discord.js/typings/index.d.ts
Lines 4618 to 4632 in af837de
[AuditLogEvent.ChannelOverwriteCreate]: | |
| Role | |
| GuildMember | |
| { id: Snowflake; name: string; type: 'Role' } | |
| { id: Snowflake; type: 'Member' }; | |
[AuditLogEvent.ChannelOverwriteUpdate]: | |
| Role | |
| GuildMember | |
| { id: Snowflake; name: string; type: 'Role' } | |
| { id: Snowflake; type: 'Member' }; | |
[AuditLogEvent.ChannelOverwriteDelete]: | |
| Role | |
| GuildMember | |
| { id: Snowflake; name: string; type: OverwriteType.Role } | |
| { id: Snowflake; type: OverwriteType.Member }; |
It seems the first two events still use the string variant and the third event uses OverwriteType
instead of AuditLogOptionsType
.
Please describe the changes this PR makes and why it should be merged:
Status and versioning classification: