Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ShardClientUtil#_respond): construct global error #8348

Merged
merged 1 commit into from Jul 24, 2022

Conversation

didinele
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Currently, if something goes wrong here, we don't get a proper error, because Error here refers to our error class. This is meant to throw a global Error. This is likely caused because of #8068

this.send(message).catch(err => {
const error = new Error(`Error when sending ${type} response to master process: ${err.message}`);
error.stack = err.stack;

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Jul 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Jul 24, 2022 at 0:53AM (UTC)

@iCrawl iCrawl merged commit 8e520f9 into discordjs:main Jul 24, 2022
@didinele didinele deleted the fix/broadcast-eval-error branch July 24, 2022 14:20
@nyapat nyapat mentioned this pull request Jul 25, 2022
@kyranet kyranet linked an issue Jul 25, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Broadcast eval erroring
4 participants