fix(GuildChannelManager): allow unsetting rtcRegion #8359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kyranet
approved these changes
Jul 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #8359 +/- ##
==========================================
- Coverage 86.43% 86.40% -0.04%
==========================================
Files 87 87
Lines 8218 8221 +3
Branches 1098 1098
==========================================
Hits 7103 7103
- Misses 1072 1075 +3
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
iCrawl
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR fixes the ability of
GuildChannelManager#edit(and indirectlyGuildChannel#editas well asBaseGuildVoiceChannel#setRTCRegion) to unset the rtc region by providingnull.The cause for this was that the method was using
??to default to the current value if the provided value was missing or nullish.(Why are we even sending the current values back? They are optional. 🤔 )
Status and versioning classification: