Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Use info blocks for requirements #8361

Merged
merged 1 commit into from Jul 27, 2022
Merged

docs: Use info blocks for requirements #8361

merged 1 commit into from Jul 27, 2022

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jul 25, 2022 •
edited

Please describe the changes this PR makes and why it should be merged:

  • Standardises requirements for an event, method or property (This event/method/property requires the...)
  • Places requirements in info tags to be more visible
  • Links don't work in in-line code which caused Client#event:inviteDelete to break
  • Typo in Activity#toString()

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Jul 25, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Jul 25, 2022 at 4:31PM (UTC)

@Jiralite Jiralite added this to the discord.js v14.1 milestone Jul 25, 2022
@vercel vercel bot temporarily deployed to Preview July 25, 2022 16:25 Inactive
@vercel vercel bot temporarily deployed to Preview July 25, 2022 16:31 Inactive
@iCrawl iCrawl merged commit 80b9738 into discordjs:main Jul 27, 2022
@Jiralite Jiralite deleted the docs/markdown-things branch July 27, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@kyranet kyranet Awaiting requested review from kyranet

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
documentation packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js v14.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jiralite @iCrawl @SpaceEEC