New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Deprecate Formatter
class
#8373
Merged
iCrawl
merged 4 commits into
discordjs:main
from
Jiralite:refactor/deprecate-formatters
Jul 27, 2022
Merged
refactor: Deprecate Formatter
class
#8373
iCrawl
merged 4 commits into
discordjs:main
from
Jiralite:refactor/deprecate-formatters
Jul 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
July 26, 2022 22:15
imranbarbhuiya
suggested changes
Jul 27, 2022
Jiralite
force-pushed
the
refactor/deprecate-formatters
branch
from
July 27, 2022 09:09
6e8ed49
to
1ce3eba
Compare
Jiralite
force-pushed
the
refactor/deprecate-formatters
branch
from
July 27, 2022 09:14
1ce3eba
to
1a88564
Compare
ImRodry
reviewed
Jul 27, 2022
Jiralite
force-pushed
the
refactor/deprecate-formatters
branch
from
July 27, 2022 10:48
1582847
to
080622e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Everything in this class is already exported at the top level. This just leads to code duplication.
string
types have been updated toSnowflake
typesTimestampStylesString
from the class in the typings. It didn't even exist!Status and versioning classification: