Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Deprecate Formatter class #8373

Merged
merged 4 commits into from Jul 27, 2022

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jul 26, 2022

Please describe the changes this PR makes and why it should be merged:
Everything in this class is already exported at the top level. This just leads to code duplication.

  • Some string types have been updated to Snowflake types
  • Optional parameters were properly documented
  • Documented all the methods as top-level functions. Previously, they weren't documented
  • Removed TimestampStylesString from the class in the typings. It didn't even exist!
  • Deprecated the class (with emitted warnings)

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Jul 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 11:05AM (UTC)

@vercel vercel bot temporarily deployed to Preview July 26, 2022 22:18 Inactive
@Jiralite Jiralite added this to the discord.js v14.1 milestone Jul 27, 2022
@Jiralite Jiralite marked this pull request as ready for review July 27, 2022 00:27
@vercel vercel bot temporarily deployed to Preview July 27, 2022 00:29 Inactive
@Jiralite Jiralite force-pushed the refactor/deprecate-formatters branch from 6e8ed49 to 1ce3eba Compare July 27, 2022 09:09
@vercel vercel bot temporarily deployed to Preview July 27, 2022 09:12 Inactive
@Jiralite Jiralite force-pushed the refactor/deprecate-formatters branch from 1ce3eba to 1a88564 Compare July 27, 2022 09:14
@vercel vercel bot temporarily deployed to Preview July 27, 2022 09:17 Inactive
@vercel vercel bot temporarily deployed to Preview July 27, 2022 09:33 Inactive
@Jiralite Jiralite force-pushed the refactor/deprecate-formatters branch from 1582847 to 080622e Compare July 27, 2022 10:48
@vercel vercel bot temporarily deployed to Preview July 27, 2022 10:51 Inactive
@vercel vercel bot temporarily deployed to Preview July 27, 2022 11:05 Inactive
@iCrawl iCrawl merged commit 7fd9ed8 into discordjs:main Jul 27, 2022
@Jiralite Jiralite deleted the refactor/deprecate-formatters branch July 27, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants