Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(WebhookClient): Document working options #8375

Merged
merged 2 commits into from Jul 27, 2022

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jul 27, 2022

Please describe the changes this PR makes and why it should be merged:
A webhook client only utilises two options: allowedMentions and rest. Linking ClientOptions reveals a bunch of options that webhooks cannot use. The documentation has been updated to reflect what webhook clients can actually use. The typings already appear to have this sorted out.

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Jul 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 11:04AM (UTC)

@Jiralite Jiralite force-pushed the docs/webhook-client-options branch from 2e18dcb to b964340 Compare July 27, 2022 10:34
@Jiralite Jiralite added this to the discord.js v14.1 milestone Jul 27, 2022
@vercel vercel bot temporarily deployed to Preview July 27, 2022 10:39 Inactive
@vercel vercel bot temporarily deployed to Preview July 27, 2022 11:04 Inactive
@iCrawl iCrawl merged commit ba6797e into discordjs:main Jul 27, 2022
@Jiralite Jiralite deleted the docs/webhook-client-options branch July 27, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants