Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataResolver): make Buffer from string #8416

Merged
merged 1 commit into from Aug 8, 2022

Conversation

Syjalo
Copy link
Contributor

@Syjalo Syjalo commented Aug 2, 2022

Please describe the changes this PR makes and why it should be merged:
Buffer.concat(Array<string>) is not a thing and we get an error when using a Stream.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Aug 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 9:23PM (UTC)

@vercel vercel bot temporarily deployed to Preview August 2, 2022 21:23 Inactive
@Jiralite Jiralite added this to the discord.js v14.2 milestone Aug 3, 2022
@iCrawl iCrawl merged commit e72b986 into discordjs:main Aug 8, 2022
@Syjalo Syjalo deleted the fix-DataResolver.resolveFile() branch August 8, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants