Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MessageMentions): infinite loop in parsedUsers getter #8430

Merged
merged 2 commits into from Aug 8, 2022
Merged

fix(MessageMentions): infinite loop in parsedUsers getter #8430

merged 2 commits into from Aug 8, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Aug 4, 2022

Please describe the changes this PR makes and why it should be merged:
Fixes #8426

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Aug 4, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Aug 5, 2022 at 5:16PM (UTC)

@vercel vercel bot temporarily deployed to Preview August 4, 2022 08:49 Inactive
@Jiralite Jiralite added this to the discord.js v14.2 milestone Aug 4, 2022
SpaceEEC
SpaceEEC requested changes Aug 4, 2022
View reviewed changes
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview August 5, 2022 17:16 Inactive
@kyranet kyranet requested a review from SpaceEEC August 6, 2022 07:09
@iCrawl iCrawl merged commit b8a3136 into discordjs:main Aug 8, 2022
@almeidx almeidx deleted the discord.js/fix-parsedUsers branch August 8, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js v14.2
Development

Successfully merging this pull request may close these issues.

Infinite loop on MessageMentions parsedUsers getter
6 participants
@almeidx @vladfrangu @iCrawl @kyranet @SpaceEEC @Jiralite