types(ApplicationCommandOption): add ApplicationCommandBooleanOption
#8434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `ApplicationCommandOptionType.Boolean` to `CommandOptionChoiceResolvableType` union Add interface `ApplicationCommandBooleanOptionData` Add interface `ApplicationCommandBooleanOption` Add `ApplicationCommandBooleanOption` to `ApplicationCommandSubCommandData.options` union Add `ApplicationCommandBooleanOptionData` to `ApplicationCommandOptionData` union Add `ApplicationCommandBooleanOption` to `ApplicationCommandOption` union
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
Syjalo
suggested changes
Aug 4, 2022
Make `ApplicationCommandBooleanOptionData` inherit from `BaseApplicationCommandOptionsData` Make `ApplicationCommandBooleanOption` inherit from `BaseApplicationCommandOptionsData` Remove `ApplicationCommandOptionType.Boolean` from `CommandOptionChoiceResolvableType` union Fixes Boolean option type appearing as a choice.
|
Could you possibly expand this fix for other types too? |
|
I'll have a look into it, but don't want to promise anything. This is my first time working on d.js' code base, so I don't know what kind of unforseen issues I'll run into. |
iCrawl
approved these changes
Aug 10, 2022
vladfrangu
approved these changes
Aug 10, 2022
kyranet
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Add
ApplicationCommandOptionType.BooleantoCommandOptionChoiceResolvableTypeunionAdd interface
ApplicationCommandBooleanOptionDataAdd interface
ApplicationCommandBooleanOptionAdd
ApplicationCommandBooleanOptiontoApplicationCommandSubCommandData.optionsunionAdd
ApplicationCommandBooleanOptionDatatoApplicationCommandOptionDataunionAdd
ApplicationCommandBooleanOptiontoApplicationCommandOptionunionFixes #8433
Status and versioning classification: