types: fix missing types for mentionable options #8443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `ApplicationCommandRoleOptionData` interface - Add `ApplicationCommandRoleOption` interface - Add `ApplicationCommandUserOptionData` interface - Add `ApplicationCommandUserOption` interface - Add `ApplicationCommandMentionableOptionData` interface - Add `ApplicationCommandMentionableOption` interface - Update `ApplicationCommandSubCommandData.options` union - Update `ApplicationCommandOptionData` union - Update `ApplicationCommandOption` union
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
kyranet
previously requested changes
Aug 7, 2022
Co-authored-by: A. Román <kyradiscord@gmail.com>
iCrawl
approved these changes
Aug 10, 2022
vladfrangu
approved these changes
Aug 10, 2022
kyranet
approved these changes
Aug 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #8443 +/- ##
==========================================
+ Coverage 86.41% 91.93% +5.52%
==========================================
Files 87 75 -12
Lines 8286 6856 -1430
Branches 1104 1018 -86
==========================================
- Hits 7160 6303 -857
+ Misses 1083 511 -572
+ Partials 43 42 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
ApplicationCommandRoleOptionDatainterfaceApplicationCommandRoleOptioninterfaceApplicationCommandUserOptionDatainterfaceApplicationCommandUserOptioninterfaceApplicationCommandMentionableOptionDatainterfaceApplicationCommandMentionableOptioninterfaceApplicationCommandSubCommandData.optionsunionApplicationCommandOptionDataunionApplicationCommandOptionunionFixes #8440
Status and versioning classification: