Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change registration example to use global commands #8454

Merged
merged 1 commit into from Aug 10, 2022

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Aug 9, 2022

Please describe the changes this PR makes and why it should be merged:

Global commands are more familiar to users and make more sense in an example with little context. With commands v2, global commands deploy instantly so there is no point in using guild commands.

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Aug 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Aug 9, 2022 at 1:04AM (UTC)

@vercel vercel bot temporarily deployed to Preview August 9, 2022 01:04 Inactive
@almostSouji
Copy link
Member

I disagree that there is no point in guild commands. First-time developers should build the habit of deploying commands to a test server before releasing them into the wild, testing them to make sure they do what they expect them to.

That being said, I could see that covered as a note, or maybe even with both, annotated, in the same example.
A ping-pong demonstration of a proof of concept to be a global "finished" command seems slightly absurd to me.

@vladfrangu
Copy link
Member

I agree with @almostSouji, however that sort of content feels more appropriate for our guides (educating on the difference, and teaching users to start off with guild commands and then migrate to global ones). Personally I think having the ping pong command example as global is fine, but it should definitely tell the users to read more on our guides for more examples

@iCrawl iCrawl merged commit 64a4041 into discordjs:main Aug 10, 2022
@advaith1 advaith1 deleted the example-global-commands branch September 11, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants