Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove DM channels from Client#messageDeleteBulk's types #8460

Merged
merged 1 commit into from Aug 10, 2022

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Aug 9, 2022

Please describe the changes this PR makes and why it should be merged:
The channel parameter from Client#messageDeleteBulk was of type TextBasedChannel. This included DM channels, which is not possible as documented:

This endpoint can only be used on guild channels

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Aug 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Aug 9, 2022 at 11:50PM (UTC)

@iCrawl iCrawl merged commit 6c6fe74 into discordjs:main Aug 10, 2022
@Jiralite Jiralite deleted the fix/bulk-delete-guild-only branch August 10, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants