Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Transformers): do not transform Date objects #8463

Merged
merged 1 commit into from Aug 10, 2022

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Aug 10, 2022

Please describe the changes this PR makes and why it should be merged:

Alternative to #8458, adds a check to not convert Date objects into non-Date.

image

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Aug 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Aug 10, 2022 at 2:13PM (UTC)

@kyranet kyranet linked an issue Aug 10, 2022 that may be closed by this pull request
@Jiralite Jiralite added this to the discord.js v14.2 milestone Aug 10, 2022
@vercel vercel bot temporarily deployed to Preview August 10, 2022 14:13 Inactive
@iCrawl iCrawl merged commit 0e2a095 into discordjs:main Aug 10, 2022
@kyranet kyranet deleted the fix/discordjs/do-not-transform-date branch August 10, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Using timestamp with EmbedBuilder: RangeError: Invalid time value
3 participants