Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(Message): correct bulkDelete return type #8465

Merged
merged 3 commits into from Aug 10, 2022
Merged

Conversation

RedGuy12
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Resolves #8410 (Partially)
This implements the patch fix detailed in #8410. I updated both the typings and the docs.

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Signed-off-by: RedGuy12 <paul@reid-family.org>
@vercel
Copy link

vercel bot commented Aug 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Aug 10, 2022 at 6:21PM (UTC)

@vercel vercel bot temporarily deployed to Preview August 10, 2022 16:58 Inactive
@vercel vercel bot temporarily deployed to Preview August 10, 2022 17:07 Inactive
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview August 10, 2022 18:21 Inactive
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #8465 (a6371b6) into main (aac8acc) will decrease coverage by 1.99%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8465      +/-   ##
==========================================
- Coverage   86.41%   84.41%   -2.00%     
==========================================
  Files          87       77      -10     
  Lines        8286     6250    -2036     
  Branches     1104      871     -233     
==========================================
- Hits         7160     5276    -1884     
+ Misses       1083      934     -149     
+ Partials       43       40       -3     
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 73.28% <ø> (ø)
rest ?
utilities 100.00% <ø> (ø)
voice 64.08% <ø> (ø)
ws 59.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/rest/src/lib/utils/utils.ts
packages/rest/src/lib/utils/constants.ts
packages/rest/src/lib/REST.ts
packages/rest/src/lib/errors/HTTPError.ts
...ackages/rest/src/lib/handlers/SequentialHandler.ts
packages/rest/src/lib/CDN.ts
packages/rest/src/lib/errors/RateLimitError.ts
packages/rest/src/lib/errors/DiscordAPIError.ts
packages/rest/src/lib/handlers/IHandler.ts
packages/rest/src/lib/RequestManager.ts

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iCrawl iCrawl merged commit c5b96a1 into discordjs:main Aug 10, 2022
@RedGuy12 RedGuy12 deleted the gh-8410 branch August 10, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

incorrect bulkDelete return type
6 participants