Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Embed): Reference video in video #8473

Merged
merged 1 commit into from Aug 12, 2022
Merged

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Resolves #8472 by retrieving the video data instead of the image data when accessing... video data.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Aug 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Aug 11, 2022 at 9:56AM (UTC)

@Jiralite Jiralite added this to the discord.js v14.3 milestone Aug 11, 2022
@vercel vercel bot temporarily deployed to Preview August 11, 2022 09:56 Inactive
@iCrawl iCrawl merged commit c97977a into discordjs:main Aug 12, 2022
@Jiralite Jiralite deleted the fix/embed-video branch August 12, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Embed video getter errors out on embeds with videos
4 participants