Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: change type of ApplicationCommandSubCommand.options #8476

Merged
merged 3 commits into from Aug 16, 2022
Merged

types: change type of ApplicationCommandSubCommand.options #8476

merged 3 commits into from Aug 16, 2022

Conversation

ZyXProFR
Copy link
Contributor

@ZyXProFR ZyXProFR commented Aug 12, 2022

Please describe the changes this PR makes and why it should be merged:

This PR changes the type of the ApplicationCommandSubCommand.options field in order to match the documentation and be able to use all the properties of this type (like minValue, maxValue, etc).

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes

@vercel
Copy link

vercel bot commented Aug 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Aug 16, 2022 at 2:34PM (UTC)

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit ebaf158 into discordjs:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants