Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WebSocketShard): support new resume url #8480

Merged
merged 2 commits into from Aug 14, 2022

Conversation

didinele
Copy link
Member

@didinele didinele commented Aug 12, 2022

Please describe the changes this PR makes and why it should be merged:
See discord/discord-api-docs#5282

Closes #8461

Also bumps discord-api-types across the repo since.. I needed it.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Aug 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Aug 12, 2022 at 2:38PM (UTC)

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #8480 (874ee5c) into main (c97977a) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #8480   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files          87       87           
  Lines        8286     8290    +4     
  Branches     1104     1104           
=======================================
+ Hits         7160     7164    +4     
  Misses       1083     1083           
  Partials       43       43           
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 73.28% <ø> (ø)
rest 92.53% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 64.08% <ø> (ø)
ws 60.04% <50.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/ws/src/ws/WebSocketShard.ts 22.85% <0.00%> (ø)
packages/ws/src/ws/WebSocketManager.ts 98.56% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

packages/ws/src/ws/WebSocketManager.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview August 12, 2022 14:38 Inactive
@Jiralite Jiralite added this to the ws v1 milestone Aug 12, 2022
@iCrawl iCrawl merged commit bc06cc6 into discordjs:main Aug 14, 2022
@iCrawl iCrawl modified the milestones: ws v1, ws v1.1 Aug 22, 2022
@didinele didinele deleted the feat/resume-url branch January 3, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

RFC(ws): Session-specific Gateway Resume URLs
7 participants