types(ModalMessageModalSubmitInteraction): channelId is not nullable #8496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
|
yeah idk why the CI is failing but I didn't touch that |
vladfrangu
approved these changes
Aug 16, 2022
ci is failing after c052f56 commit as docgen package has some typings issue |
SpaceEEC
approved these changes
Aug 16, 2022
iCrawl
force-pushed
the
types/modalmessageint-channelid
branch
from
c8ef4a0
to
b571851
Compare
iCrawl
approved these changes
Aug 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #8496 +/- ##
=======================================
Coverage 86.49% 86.50%
=======================================
Files 87 87
Lines 8339 8341 +2
Branches 1104 1104
=======================================
+ Hits 7213 7215 +2
Misses 1083 1083
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR marks channelId as not nullable in ModalMessageModalSubmitInteraction. I had to make this commit through GitHub because the pre-commit hooks kept failing for some reason but I hope this is all that needs to be done
Status and versioning classification: