Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Implement max/min values for autocomplete #8498

Merged
merged 3 commits into from Aug 16, 2022

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Aug 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Aug 16, 2022 at 8:32PM (UTC)

@Jiralite Jiralite force-pushed the types/autocomplete-min-max-support branch from 0379ec4 to e07d31d Compare August 16, 2022 14:50
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #8498 (1fb5d16) into main (a1dddd6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1fb5d16 differs from pull request most recent head a5271fc. Consider uploading reports for the commit a5271fc to get more accurate results

@@           Coverage Diff           @@
##             main    #8498   +/-   ##
=======================================
  Coverage   86.49%   86.50%           
=======================================
  Files          87       87           
  Lines        8339     8341    +2     
  Branches     1104     1104           
=======================================
+ Hits         7213     7215    +2     
  Misses       1083     1083           
  Partials       43       43           
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 73.28% <ø> (ø)
rest 92.53% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 64.08% <ø> (ø)
ws 60.34% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/ws/src/utils/utils.ts 100.00% <100.00%> (ø)
packages/ws/src/ws/WebSocketManager.ts 98.60% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 812f7f1 into discordjs:main Aug 16, 2022
@Jiralite Jiralite deleted the types/autocomplete-min-max-support branch August 16, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants