Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GuildMemberManager): addRole and removeRole #8510

Merged
merged 2 commits into from Aug 18, 2022

Conversation

didinele
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Supersedes #8400.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Aug 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 7:10AM (UTC)

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #8510 (af20d8d) into main (d97cd93) will decrease coverage by 3.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8510      +/-   ##
==========================================
- Coverage   89.37%   86.29%   -3.09%     
==========================================
  Files          66       87      +21     
  Lines        7343     8363    +1020     
  Branches      899     1105     +206     
==========================================
+ Hits         6563     7217     +654     
- Misses        776     1103     +327     
- Partials        4       43      +39     
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <100.00%> (ø)
proxy 73.28% <ø> (ø)
rest 92.53% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 64.08% <ø> (?)
ws 59.57% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/collection/src/collection.ts 100.00% <100.00%> (ø)
packages/ws/src/utils/utils.ts 100.00% <100.00%> (ø)
packages/ws/src/ws/WebSocketManager.ts 95.62% <100.00%> (+0.01%) ⬆️
packages/voice/src/joinVoiceChannel.ts 100.00% <0.00%> (ø)
packages/voice/src/DataStore.ts 98.11% <0.00%> (ø)
packages/voice/src/audio/TransformerGraph.ts 74.60% <0.00%> (ø)
packages/voice/src/audio/PlayerSubscription.ts 50.00% <0.00%> (ø)
packages/voice/src/networking/Networking.ts 3.18% <0.00%> (ø)
packages/voice/src/receive/SSRCMap.ts 86.20% <0.00%> (ø)
packages/voice/src/util/abortAfter.ts 100.00% <0.00%> (ø)
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel vercel bot temporarily deployed to Preview August 18, 2022 07:10 Inactive
@iCrawl iCrawl merged commit cda3f00 into discordjs:main Aug 18, 2022
@didinele didinele deleted the feat/guild-member-manager-endpoints branch August 18, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants