Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(GuildAuditLogsEntry): Remove guild from application command permission update extra #8520

Merged
merged 2 commits into from Aug 20, 2022

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
When fetching an entry which is of an application command permission update, <GuildAuditLogsEntry>.extra.guild is always undefined. This is not documented, so it will be removed. It was useless anyway as we are already in a guild context.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Aug 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Aug 20, 2022 at 6:48PM (UTC)

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #8520 (818ddb2) into main (8028813) will increase coverage by 7.65%.
The diff coverage is n/a.

❗ Current head 818ddb2 differs from pull request most recent head c275609. Consider uploading reports for the commit c275609 to get more accurate results

@@            Coverage Diff             @@
##             main    #8520      +/-   ##
==========================================
+ Coverage   78.73%   86.38%   +7.65%     
==========================================
  Files          22       87      +65     
  Lines        3503     8418    +4915     
  Branches      320     1105     +785     
==========================================
+ Hits         2758     7272    +4514     
- Misses        741     1103     +362     
- Partials        4       43      +39     
Flag Coverage Δ
builders 100.00% <ø> (?)
collection 100.00% <ø> (?)
proxy 73.28% <ø> (?)
rest 92.53% <ø> (ø)
utilities 100.00% <ø> (?)
voice 64.08% <ø> (?)
ws 59.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/voice/src/audio/PlayerSubscription.ts 50.00% <0.00%> (ø)
...ApplicationCommandNumericOptionMinMaxValueMixin.ts 100.00% <0.00%> (ø)
...ixins/ApplicationCommandOptionChannelTypesMixin.ts 100.00% <0.00%> (ø)
packages/builders/src/components/ActionRow.ts 100.00% <0.00%> (ø)
packages/builders/src/messages/embed/Assertions.ts 100.00% <0.00%> (ø)
packages/voice/src/util/demuxProbe.ts 93.33% <0.00%> (ø)
packages/voice/src/networking/VoiceUDPSocket.ts 90.47% <0.00%> (ø)
...ionCommandOptionWithChoicesAndAutocompleteMixin.ts 100.00% <0.00%> (ø)
...src/interactions/contextMenuCommands/Assertions.ts 100.00% <0.00%> (ø)
...s/contextMenuCommands/ContextMenuCommandBuilder.ts 100.00% <0.00%> (ø)
... and 55 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel vercel bot temporarily deployed to Preview August 20, 2022 18:48 Inactive
@kodiakhq kodiakhq bot merged commit 2b8074d into discordjs:main Aug 20, 2022
@Jiralite Jiralite deleted the fix/audit-log-extra-undefined-value branch August 20, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants