New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types(GuildAuditLogs): Allow fetching to return all possible values #8522
types(GuildAuditLogs): Allow fetching to return all possible values #8522
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
bcaf81c
to
c3d21d6
Compare
Codecov Report
@@ Coverage Diff @@
## main #8522 +/- ##
==========================================
+ Coverage 78.73% 86.38% +7.65%
==========================================
Files 22 87 +65
Lines 3503 8418 +4915
Branches 320 1105 +785
==========================================
+ Hits 2758 7272 +4514
- Misses 741 1103 +362
- Partials 4 43 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
c3d21d6
to
cb29146
Compare
Please describe the changes this PR makes and why it should be merged:
This resolves #8275. To explain: the issue was that calling
<Guild>.fetchAuditLogs()
(or<Guild>.fetchAuditLogs({ type: null })
) would incorrectly assume that the returnedaction
is alwaysnull
,actionType
is alwaysALL
,extra
is alwaysnull
etc. instead of leaving these as all possible values.A code sample of how this bug was in effect:
Status and versioning classification: