Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Correct EventEmitter.on (static) return type #8524

Merged
merged 2 commits into from Aug 20, 2022

Conversation

InkoHX
Copy link
Sponsor Contributor

@InkoHX InkoHX commented Aug 19, 2022

Please describe the changes this PR makes and why it should be merged:

Fix return type of EventEmitter.on (static) to AsyncIterableIterator, AsyncIterator is incorrect.

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Aug 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Aug 20, 2022 at 6:42PM (UTC)

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #8524 (1a5e11f) into main (8028813) will increase coverage by 7.72%.
The diff coverage is n/a.

❗ Current head 1a5e11f differs from pull request most recent head 032ae86. Consider uploading reports for the commit 032ae86 to get more accurate results

@@            Coverage Diff             @@
##             main    #8524      +/-   ##
==========================================
+ Coverage   78.73%   86.45%   +7.72%     
==========================================
  Files          22       87      +65     
  Lines        3503     8462    +4959     
  Branches      320     1105     +785     
==========================================
+ Hits         2758     7316    +4558     
- Misses        741     1103     +362     
- Partials        4       43      +39     
Flag Coverage Δ
builders 100.00% <ø> (?)
collection 100.00% <ø> (?)
proxy 73.28% <ø> (?)
rest 92.53% <ø> (ø)
utilities 100.00% <ø> (?)
voice 64.08% <ø> (?)
ws 59.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/proxy/src/util/util.ts 0.00% <0.00%> (ø)
packages/voice/src/receive/AudioReceiveStream.ts 100.00% <0.00%> (ø)
packages/builders/src/components/ActionRow.ts 100.00% <0.00%> (ø)
packages/voice/src/util/entersState.ts 100.00% <0.00%> (ø)
packages/builders/src/components/Assertions.ts 100.00% <0.00%> (ø)
...ges/builders/src/components/textInput/TextInput.ts 100.00% <0.00%> (ø)
...ackages/voice/src/util/generateDependencyReport.ts 0.00% <0.00%> (ø)
packages/collection/src/collection.ts 100.00% <0.00%> (ø)
packages/builders/src/messages/embed/Embed.ts 100.00% <0.00%> (ø)
packages/builders/src/util/componentUtil.ts 100.00% <0.00%> (ø)
... and 55 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel vercel bot temporarily deployed to Preview August 20, 2022 18:42 Inactive
@kodiakhq kodiakhq bot merged commit 16bbc8a into discordjs:main Aug 20, 2022
@InkoHX InkoHX deleted the fix-emitter-on-types branch August 20, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants