Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Guild): Widget channel types and fixes #8530

Merged
merged 2 commits into from Aug 21, 2022

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

  1. Upon receiving a guild from Discord, I noticed Guild#widgetEnabled and Guild#widgetChannelId did not exist. This was documented as potentially missing, so a null fallback has been added.
  2. A widget channel can actually be more than a text channel. It can be an announcement channel, a voice channel and a stage channel too. Any other channel type returns an API error from Discord.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Aug 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Aug 21, 2022 at 9:24AM (UTC)

@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #8530 (a76bd65) into main (8028813) will increase coverage by 7.72%.
The diff coverage is n/a.

❗ Current head a76bd65 differs from pull request most recent head 162b94b. Consider uploading reports for the commit 162b94b to get more accurate results

@@            Coverage Diff             @@
##             main    #8530      +/-   ##
==========================================
+ Coverage   78.73%   86.45%   +7.72%     
==========================================
  Files          22       87      +65     
  Lines        3503     8462    +4959     
  Branches      320     1105     +785     
==========================================
+ Hits         2758     7316    +4558     
- Misses        741     1103     +362     
- Partials        4       43      +39     
Flag Coverage Δ
builders 100.00% <ø> (?)
collection 100.00% <ø> (?)
proxy 73.28% <ø> (?)
rest 92.53% <ø> (ø)
utilities 100.00% <ø> (?)
voice 64.08% <ø> (?)
ws 59.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/voice/src/audio/AudioPlayer.ts 80.55% <0.00%> (ø)
packages/voice/src/receive/SSRCMap.ts 86.20% <0.00%> (ø)
packages/voice/src/util/entersState.ts 100.00% <0.00%> (ø)
...s/src/interactions/slashCommands/options/number.ts 100.00% <0.00%> (ø)
...s/builders/src/components/selectMenu/SelectMenu.ts 100.00% <0.00%> (ø)
packages/builders/src/util/validation.ts 100.00% <0.00%> (ø)
packages/voice/src/util/Secretbox.ts 33.33% <0.00%> (ø)
packages/builders/src/components/Assertions.ts 100.00% <0.00%> (ø)
packages/voice/src/joinVoiceChannel.ts 100.00% <0.00%> (ø)
packages/voice/src/networking/VoiceUDPSocket.ts 90.47% <0.00%> (ø)
... and 55 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 23a0b6c into discordjs:main Aug 21, 2022
@Jiralite Jiralite deleted the fix/widget-fixes branch August 21, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants