New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: Inference of guild in MessageManager
#8538
types: Inference of guild in MessageManager
#8538
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MessageManager
Codecov Report
@@ Coverage Diff @@
## main #8538 +/- ##
============================================
- Coverage 100.00% 86.45% -13.55%
============================================
Files 39 87 +48
Lines 3018 8462 +5444
Branches 406 1105 +699
============================================
+ Hits 3018 7316 +4298
- Misses 0 1103 +1103
- Partials 0 43 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Please describe the changes this PR makes and why it should be merged:
Consider this:
There is no way
sentMessage
could be from a direct message channel. This is a bit of a nuisance, so the typings have been adjusted to ensureMessageManager
knows whether it is in a guild or not. With this pull request,sentMessage
will beMessage<true>
.Status and versioning classification: