feat: add chatInputApplicationCommandMention formatter
#8546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
Codecov Report
@@ Coverage Diff @@
## main #8546 +/- ##
==========================================
+ Coverage 86.36% 86.47% +0.10%
==========================================
Files 87 87
Lines 8610 8679 +69
Branches 1106 1110 +4
==========================================
+ Hits 7436 7505 +69
Misses 1132 1132
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Upstream PR merged |
almeidx
force-pushed
the
builders/command-mention
branch
from
cc20829
to
88ec881
Compare
iCrawl
approved these changes
Aug 23, 2022
vladfrangu
approved these changes
Aug 30, 2022
iCrawl
force-pushed
the
builders/command-mention
branch
from
88ec881
to
7a59efc
Compare
almeidx
force-pushed
the
builders/command-mention
branch
from
7a59efc
to
487e72b
Compare
kyranet
approved these changes
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
chatInputApplicationCommandMention()formatted in /buildersAddedApplicationCommand#toString(), which will use the function mentioned above to return the commands mentionNot going to add the mention to
ApplicationCommand#toString()due to not being able to have a consistent return type. (The mentions only apply to Chat Input commands)Upstream:
Status and versioning classification: