Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(GuildChannelManager): correct fetch return type (v13) #8551

Merged
merged 5 commits into from Sep 13, 2022
Merged

types(GuildChannelManager): correct fetch return type (v13) #8551

merged 5 commits into from Sep 13, 2022

Conversation

RedGuy12
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Backports #8549 to v13.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Aug 23, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ❌ Failed (Inspect) Sep 5, 2022 at 5:12PM (UTC)

@vercel vercel bot temporarily deployed to Preview August 23, 2022 21:01 Inactive
@Jiralite Jiralite added this to the discord.js v13.11 milestone Aug 23, 2022
@vercel vercel bot temporarily deployed to Preview August 23, 2022 22:00 Inactive
@RedGuy12
types: allow channels in the collection to be null
95e0033 
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview September 5, 2022 17:06 Inactive
@RedGuy12
style: run prettier
c0535ba 
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview September 5, 2022 17:08 Inactive
@RedGuy12
test: fix types again
81bf261 
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview September 5, 2022 17:12 Inactive
@iCrawl iCrawl merged commit f4e8133 into discordjs:v13 Sep 13, 2022
@RedGuy12 RedGuy12 deleted the gh-8549-v13 branch September 13, 2022 16:04
@RedGuy12 RedGuy12 mentioned this pull request Oct 4, 2022
Closed
@RedGuy12 RedGuy12 mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
packages:discord.js semver:patch typings
Projects
None yet
Milestone
discord.js v13.11
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@RedGuy12 @vladfrangu @iCrawl @kyranet @SpaceEEC @Jiralite