Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(ThreadChannel): fetchStarterMessage must return a Message<true> #8560

Merged
merged 4 commits into from Sep 2, 2022

Conversation

RedGuy12
Copy link
Contributor

@RedGuy12 RedGuy12 commented Aug 27, 2022

Please describe the changes this PR makes and why it should be merged:
Since threads are not supported in DMs, the Message returned by fetchStarterMessage must have inGuild = true.
Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

…ue>`

Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Aug 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 6:44PM (UTC)

@vercel vercel bot temporarily deployed to Preview August 30, 2022 20:23 Inactive
@vercel vercel bot temporarily deployed to Preview September 1, 2022 20:20 Inactive
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #8560 (a00dac5) into main (3b7ba40) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head a00dac5 differs from pull request most recent head 4de1541. Consider uploading reports for the commit 4de1541 to get more accurate results

@@            Coverage Diff             @@
##             main    #8560      +/-   ##
==========================================
+ Coverage   86.35%   86.37%   +0.02%     
==========================================
  Files          86       87       +1     
  Lines        8598     8611      +13     
  Branches     1102     1107       +5     
==========================================
+ Hits         7425     7438      +13     
  Misses       1131     1131              
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 74.10% <ø> (ø)
rest 92.00% <ø> (ø)
utilities 100.00% <ø> (?)
voice 63.86% <ø> (ø)
ws 60.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/actions/src/formatTag/formatTag.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RedGuy12
Copy link
Contributor Author

RedGuy12 commented Sep 1, 2022

Tests are now passing.

@Jiralite
Copy link
Member

Jiralite commented Sep 2, 2022

Since threads are not supported in servers

You mean they are, right?

@RedGuy12
Copy link
Contributor Author

RedGuy12 commented Sep 2, 2022

Since threads are not supported in servers

You mean they are, right?

I meant in DMs

@Jiralite Jiralite added this to the discord.js v14.4 milestone Sep 2, 2022
@kodiakhq kodiakhq bot merged commit b9c62ac into discordjs:main Sep 2, 2022
@vercel vercel bot temporarily deployed to Preview September 2, 2022 18:44 Inactive
@RedGuy12 RedGuy12 deleted the fetchStarterMessage-inGuild branch September 5, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants