Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typeguard to BaseInteraction#isRepliable #8565

Merged
merged 12 commits into from Sep 6, 2022

Conversation

MaksiRose
Copy link
Contributor

@MaksiRose MaksiRose commented Aug 28, 2022

Please describe the changes this PR makes and why it should be merged:

Resolves #8563 to improve practicality of the method in typescript

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Aug 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Sep 6, 2022 at 5:52PM (UTC)

Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InteractionResponseFields seems to be no longer referenced anywhere due to this change. Perhaps it could be removed?

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
@MaksiRose
Copy link
Contributor Author

InteractionResponseFields seems to be no longer referenced anywhere due to this change. Perhaps it could be removed?

Should I add a commit to remove InteractionResponseFields?

...to exclude impossible interactions rather than specify possible ones

Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@Jiralite
Copy link
Member

Sure.

@MaksiRose MaksiRose requested review from Jiralite and removed request for vladfrangu, iCrawl, kyranet and SpaceEEC August 28, 2022 15:32
@MaksiRose
Copy link
Contributor Author

I don't know what I clicked, but I clicked something by accident and it changed the reviewers. Sorry about that

@almostSouji almostSouji requested review from vladfrangu, kyranet, iCrawl and SpaceEEC and removed request for Jiralite August 28, 2022 16:01
@vercel vercel bot temporarily deployed to Preview August 30, 2022 17:57 Inactive
@vercel vercel bot temporarily deployed to Preview August 30, 2022 22:46 Inactive
@vercel vercel bot temporarily deployed to Preview September 2, 2022 13:10 Inactive
@vercel vercel bot temporarily deployed to Preview September 3, 2022 08:28 Inactive
@vercel vercel bot temporarily deployed to Preview September 5, 2022 19:33 Inactive
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are not passing. Please look over them!

@vercel vercel bot temporarily deployed to Preview September 6, 2022 17:52 Inactive
@kodiakhq kodiakhq bot merged commit 55c3ee2 into discordjs:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

interaction.isRepliable() doesn't narrow the interaction type correctly in TS
7 participants