New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add typeguard to BaseInteraction#isRepliable #8565
feat: add typeguard to BaseInteraction#isRepliable #8565
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InteractionResponseFields
seems to be no longer referenced anywhere due to this change. Perhaps it could be removed?
Should I add a commit to remove |
...to exclude impossible interactions rather than specify possible ones Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Sure. |
I don't know what I clicked, but I clicked something by accident and it changed the reviewers. Sorry about that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are not passing. Please look over them!
Please describe the changes this PR makes and why it should be merged:
Resolves #8563 to improve practicality of the method in typescript
Status and versioning classification: