Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(interactions): fix {Slash,ContextMenu}CommandBuilder#toJSON #8568

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Aug 29, 2022

Please describe the changes this PR makes and why it should be merged:

SlashCommandBuilder and ContextMenuCommandBuilder's toJSON methods returned the base interface (RESTPostAPIApplicationCommandsJSONBody) rather than the specific interfaces they build (RESTPostAPIChatInputApplicationCommandsJSONBody and RESTPostAPIContextMenuApplicationCommandsJSONBody respectively).

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Aug 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Sep 2, 2022 at 3:24PM (UTC)

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #8568 (2f9795c) into main (3b7ba40) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8568      +/-   ##
==========================================
+ Coverage   86.35%   86.37%   +0.02%     
==========================================
  Files          86       87       +1     
  Lines        8598     8611      +13     
  Branches     1102     1107       +5     
==========================================
+ Hits         7425     7438      +13     
  Misses       1131     1131              
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <100.00%> (ø)
collection 100.00% <ø> (ø)
proxy 74.10% <ø> (ø)
rest 92.00% <ø> (ø)
utilities 100.00% <ø> (?)
voice 63.86% <ø> (ø)
ws 60.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/contextMenuCommands/ContextMenuCommandBuilder.ts 100.00% <100.00%> (ø)
.../interactions/slashCommands/SlashCommandBuilder.ts 100.00% <100.00%> (ø)
packages/actions/src/formatTag/formatTag.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iCrawl iCrawl force-pushed the types/builders/correctly-type-interaction-builder-to-json branch from c19990b to 2f9795c Compare September 2, 2022 15:24
@iCrawl iCrawl merged commit b7eb96d into discordjs:main Sep 2, 2022
@kyranet kyranet deleted the types/builders/correctly-type-interaction-builder-to-json branch October 7, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants