fix(SlashCommandBuilder): missing methods in subcommand builder #8583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
Codecov Report
@@ Coverage Diff @@
## main #8583 +/- ##
============================================
- Coverage 100.00% 86.37% -13.63%
============================================
Files 39 87 +48
Lines 3015 8610 +5595
Branches 406 1107 +701
============================================
+ Hits 3015 7437 +4422
- Misses 0 1131 +1131
- Partials 0 42 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kyranet
approved these changes
Sep 3, 2022
vladfrangu
reviewed
Sep 3, 2022
| @@ -188,8 +188,7 @@ export class SlashCommandBuilder { | |||
| export interface SlashCommandBuilder extends SharedNameAndDescription, SharedSlashCommandOptions {} | |||
|
|
|||
| export interface SlashCommandSubcommandsOnlyBuilder | |||
| extends SharedNameAndDescription, | |||
| Pick<SlashCommandBuilder, 'addSubcommand' | 'addSubcommandGroup' | 'toJSON'> {} | |||
| extends Omit<SlashCommandBuilder, Exclude<keyof SharedSlashCommandOptions, 'options'>> {} | |||
There was a problem hiding this comment.
Does this only remove the option functions or does it keep them 👀
There was a problem hiding this comment.
It omits all the methods of the SharedSlashCommandOptions mixin from the SlashCommandBuilder class
SpaceEEC
approved these changes
Sep 11, 2022
iCrawl
approved these changes
Sep 15, 2022
suneettipirneni
pushed a commit
to suneettipirneni/discord.js
that referenced
this pull request
Sep 17, 2022
suneettipirneni
pushed a commit
to suneettipirneni/discord.js
that referenced
this pull request
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Fixes #8562
Status and versioning classification: