Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Options): update DefaultMakeCacheSettings #8585

Merged
merged 2 commits into from Sep 11, 2022

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Sep 3, 2022

Please describe the changes this PR makes and why it should be merged:

lol this still hasn't been fixed

https://canary.discord.com/channels/222078108977594368/1005789149225291866

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Sep 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Sep 11, 2022 at 6:15PM (UTC)

@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Merging #8585 (6f954fd) into main (4ffdada) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8585      +/-   ##
==========================================
+ Coverage   86.47%   86.50%   +0.03%     
==========================================
  Files          87       87              
  Lines        8675     8673       -2     
  Branches     1110     1110              
==========================================
+ Hits         7502     7503       +1     
+ Misses       1131     1128       -3     
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <100.00%> (ø)
collection 100.00% <ø> (ø)
proxy 74.10% <ø> (ø)
rest 91.99% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.86% <ø> (ø)
ws 60.47% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/collection/src/collection.ts 100.00% <ø> (ø)
packages/voice/src/DataStore.ts 98.14% <ø> (ø)
packages/voice/src/networking/Networking.ts 3.18% <ø> (ø)
packages/voice/src/networking/VoiceUDPSocket.ts 90.47% <ø> (ø)
packages/voice/src/networking/VoiceWebSocket.ts 0.00% <ø> (ø)
packages/voice/src/receive/SSRCMap.ts 86.20% <ø> (ø)
packages/voice/src/receive/SpeakingMap.ts 100.00% <ø> (ø)
packages/voice/src/util/Secretbox.ts 33.33% <ø> (ø)
...trategies/context/WorkerContextFetchingStrategy.ts 92.00% <ø> (-0.16%) ⬇️
.../src/strategies/sharding/WorkerShardingStrategy.ts 95.87% <ø> (-0.02%) ⬇️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel vercel bot temporarily deployed to Preview September 11, 2022 18:15 Inactive
@kodiakhq kodiakhq bot merged commit 3252332 into discordjs:main Sep 11, 2022
@advaith1 advaith1 deleted the patch-2 branch September 12, 2022 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants