Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Split message send/edit types/documentation #8590

Merged
merged 3 commits into from Sep 11, 2022

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Sep 3, 2022

Please describe the changes this PR makes and why it should be merged:
Some general refactoring around sending and editing messages. For example, attachments showed up when sending a message when it should not - it should appear when editing. This also resolves #8587.

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Sep 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Sep 11, 2022 at 6:16PM (UTC)

@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #8590 (15c4b12) into main (4ffdada) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 15c4b12 differs from pull request most recent head 4b19cce. Consider uploading reports for the commit 4b19cce to get more accurate results

@@            Coverage Diff             @@
##             main    #8590      +/-   ##
==========================================
- Coverage   86.47%   86.47%   -0.01%     
==========================================
  Files          87       87              
  Lines        8675     8679       +4     
  Branches     1110     1110              
==========================================
+ Hits         7502     7505       +3     
- Misses       1131     1132       +1     
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 74.10% <ø> (ø)
rest 92.00% <ø> (+<0.01%) ⬆️
utilities 100.00% <ø> (ø)
voice 63.86% <ø> (ø)
ws 60.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/voice/src/VoiceConnection.ts 81.76% <0.00%> (ø)
packages/voice/src/networking/Networking.ts 3.18% <0.00%> (ø)
packages/voice/src/receive/VoiceReceiver.ts 90.56% <0.00%> (ø)
packages/rest/src/lib/errors/DiscordAPIError.ts 96.46% <0.00%> (+0.03%) ⬆️
packages/ws/src/ws/WebSocketShard.ts 23.32% <0.00%> (+0.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jiralite Jiralite force-pushed the refactor/split-message-send-edit branch from 15c4b12 to 4bfcff8 Compare September 11, 2022 15:27
@kodiakhq kodiakhq bot merged commit 8e1afae into discordjs:main Sep 11, 2022
@Jiralite Jiralite deleted the refactor/split-message-send-edit branch September 11, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Inconsistency with content property in MessageOptions
5 participants