New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add @discordjs/util
#8591
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov Report
@@ Coverage Diff @@
## main #8591 +/- ##
==========================================
- Coverage 92.09% 86.84% -5.25%
==========================================
Files 10 87 +77
Lines 2099 8811 +6712
Branches 239 1103 +864
==========================================
+ Hits 1933 7652 +5719
- Misses 163 1117 +954
- Partials 3 42 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add in labels file and workflow matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new package should have tests, some are available in @sapphire/utilities
such as lazy
, which has their tests here.
Type-only utilities can be tested with Vitest's type assertions, doing expect<T>(assertedValue);
or using tsd
like discord.js does.
d0aea20
to
5a74c14
Compare
7ca9c9d
to
901472b
Compare
Co-authored-by: Parbez <imranbarbhuiya.fsd@gmail.com> Co-authored-by: A. Román <kyradiscord@gmail.com>
688f57f
to
b4fc0cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, is .test-d.ts
an accepted (and recognised) format? Or is it run only by TSD and not by Vitest?
Please describe the changes this PR makes and why it should be merged:
Adds an internal package for utilities and types that are shared among
@discordjs
packages.Status and versioning classification: