Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: website components #8600

Merged
merged 34 commits into from Sep 6, 2022
Merged

refactor: website components #8600

merged 34 commits into from Sep 6, 2022

Conversation

iCrawl
Copy link
Member

@iCrawl iCrawl commented Sep 6, 2022

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

@vercel
Copy link

vercel bot commented Sep 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Sep 6, 2022 at 5:44PM (UTC)

"minisearch": "^5.0.0",
"next": "^12.2.5",
"next-mdx-remote": "^4.1.0",
"next-progress": "^2.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nextjs-progressbar is a good alternative with 30x more downloads

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres actually a few differences between the 2 packages, one would be allowing full custom css, which nextjs-progressbar doesn't. Plus its wrapped in a memo, which nextjs-progressbar is not.

@vercel vercel bot temporarily deployed to Preview September 6, 2022 17:30 Inactive
@vercel vercel bot temporarily deployed to Preview September 6, 2022 17:44 Inactive
@iCrawl iCrawl merged commit c334157 into main Sep 6, 2022
@iCrawl iCrawl deleted the refactor/website-components branch September 6, 2022 17:48
"@microsoft/api-extractor-model": "7.24.0",
"@microsoft/tsdoc": "0.14.1",
"@vscode/codicons": "^0.0.32",
"ariakit": "^2.0.0-next.41",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend setting it to the exact version (without ^) while it's in alpha so that you don't get breaking changes by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants