Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace usage of deprecated ChannelTypes #8625

Merged
merged 2 commits into from Sep 17, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Sep 15, 2022

Please describe the changes this PR makes and why it should be merged:
Replaces the usage of the deprecated news/thread ChannelTypes

discordjs/discord-api-types@8178841 (Released in 0.37.6)

"discord-api-types": "^0.37.8",

Status and versioning classification:

@vercel
Copy link

vercel bot commented Sep 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Sep 17, 2022 at 1:55PM (UTC)

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #8625 (e649a42) into main (1d72663) will increase coverage by 7.45%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8625      +/-   ##
==========================================
+ Coverage   79.05%   86.50%   +7.45%     
==========================================
  Files          48       87      +39     
  Lines        5585     8672    +3087     
  Branches      700     1110     +410     
==========================================
+ Hits         4415     7502    +3087     
  Misses       1128     1128              
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <100.00%> (?)
collection 100.00% <ø> (ø)
proxy 74.10% <ø> (ø)
rest 91.99% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.86% <ø> (ø)
ws 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ixins/ApplicationCommandOptionChannelTypesMixin.ts 100.00% <100.00%> (ø)
packages/builders/src/components/ActionRow.ts 100.00% <0.00%> (ø)
...s/contextMenuCommands/ContextMenuCommandBuilder.ts 100.00% <0.00%> (ø)
...src/interactions/contextMenuCommands/Assertions.ts 100.00% <0.00%> (ø)
.../src/interactions/slashCommands/options/boolean.ts 100.00% <0.00%> (ø)
packages/builders/src/messages/embed/Embed.ts 100.00% <0.00%> (ø)
...s/src/interactions/slashCommands/options/number.ts 100.00% <0.00%> (ø)
packages/builders/src/util/jsonEncodable.ts 100.00% <0.00%> (ø)
...ders/src/components/selectMenu/SelectMenuOption.ts 100.00% <0.00%> (ø)
packages/builders/src/util/normalizeArray.ts 100.00% <0.00%> (ø)
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel vercel bot temporarily deployed to Preview September 17, 2022 13:55 Inactive
@kodiakhq kodiakhq bot merged commit 669c3cd into discordjs:main Sep 17, 2022
@almeidx almeidx deleted the new-channel-types branch September 17, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants