Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update messageCount/totalMessageSent on message events #8635

Merged
merged 2 commits into from Sep 19, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Sep 18, 2022

Please describe the changes this PR makes and why it should be merged:

The message_count and total_message_sent fields on threads created in a forum will increment on MESSAGE_CREATE and will decrement on MESSAGE_DELETE/MESSAGE_DELETE_BULK. There will be no CHANNEL_UPDATE event through gateway notifying those fields' changes (similar to last_message_id changes). Clients should update those values when receiving corresponding events.

https://discord.com/developers/docs/topics/threads#forums

Status and versioning classification:

@vercel
Copy link

vercel bot commented Sep 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Sep 19, 2022 at 0:37AM (UTC)

@almeidx almeidx marked this pull request as ready for review September 18, 2022 20:50
@Jiralite Jiralite added this to the discord.js v14.4 milestone Sep 18, 2022
@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #8635 (8162d5b) into main (8444576) will decrease coverage by 13.31%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##              main    #8635       +/-   ##
============================================
- Coverage   100.00%   86.68%   -13.32%     
============================================
  Files           39       87       +48     
  Lines         3199     8784     +5585     
  Branches       410     1110      +700     
============================================
+ Hits          3199     7614     +4415     
- Misses           0     1128     +1128     
- Partials         0       42       +42     
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (?)
proxy 74.10% <ø> (?)
rest 91.99% <ø> (?)
utilities 100.00% <ø> (?)
voice 63.86% <ø> (?)
ws 60.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/voice/src/audio/AudioPlayerError.ts 0.00% <0.00%> (ø)
packages/voice/src/receive/AudioReceiveStream.ts 100.00% <0.00%> (ø)
packages/ws/src/strategies/sharding/worker.ts 0.00% <0.00%> (ø)
...ackages/rest/src/lib/handlers/SequentialHandler.ts 86.03% <0.00%> (ø)
packages/voice/src/audio/PlayerSubscription.ts 50.00% <0.00%> (ø)
packages/voice/src/receive/SSRCMap.ts 86.20% <0.00%> (ø)
packages/voice/src/audio/AudioPlayer.ts 80.95% <0.00%> (ø)
packages/ws/src/utils/utils.ts 100.00% <0.00%> (ø)
...es/ws/src/strategies/sharding/IShardingStrategy.ts 100.00% <0.00%> (ø)
packages/rest/src/lib/errors/HTTPError.ts 100.00% <0.00%> (ø)
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel vercel bot temporarily deployed to Preview September 19, 2022 00:37 Inactive
@kodiakhq kodiakhq bot merged commit 145eb2f into discordjs:main Sep 19, 2022
@almeidx almeidx deleted the discord.js/update-message-count branch September 19, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants