Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(builders/components): document constructors #8636

Merged
merged 1 commit into from Sep 19, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Sep 18, 2022

Please describe the changes this PR makes and why it should be merged:
Documents the constructors of the components, and fixed the current documentation of the ButtonBuilder

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Sep 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Sep 18, 2022 at 9:27PM (UTC)

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #8636 (9d0d01a) into main (1d72663) will increase coverage by 7.62%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8636      +/-   ##
==========================================
+ Coverage   79.05%   86.68%   +7.62%     
==========================================
  Files          48       87      +39     
  Lines        5585     8784    +3199     
  Branches      700     1110     +410     
==========================================
+ Hits         4415     7614    +3199     
  Misses       1128     1128              
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <100.00%> (?)
collection 100.00% <ø> (ø)
proxy 74.10% <ø> (ø)
rest 91.99% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.86% <ø> (ø)
ws 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/builders/src/components/ActionRow.ts 100.00% <100.00%> (ø)
packages/builders/src/components/button/Button.ts 100.00% <100.00%> (ø)
...s/builders/src/components/selectMenu/SelectMenu.ts 100.00% <100.00%> (ø)
...ders/src/components/selectMenu/SelectMenuOption.ts 100.00% <100.00%> (ø)
...ges/builders/src/components/textInput/TextInput.ts 100.00% <100.00%> (ø)
...ixins/ApplicationCommandOptionChannelTypesMixin.ts 100.00% <100.00%> (ø)
.../slashCommands/mixins/SharedSlashCommandOptions.ts 100.00% <0.00%> (ø)
...ers/src/interactions/slashCommands/options/role.ts 100.00% <0.00%> (ø)
packages/builders/src/components/Component.ts 100.00% <0.00%> (ø)
... and 35 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iCrawl iCrawl merged commit 8444576 into discordjs:main Sep 19, 2022
@almeidx almeidx deleted the builders/component-examples branch September 19, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants