Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GuildChannelManager): allow editing flags #8637

Merged
merged 2 commits into from Sep 21, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Sep 18, 2022

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Sep 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Sep 21, 2022 at 9:57PM (UTC)

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #8637 (7fa79ff) into main (30ceaf7) will increase coverage by 26.03%.
The diff coverage is n/a.

❗ Current head 7fa79ff differs from pull request most recent head 421250c. Consider uploading reports for the commit 421250c to get more accurate results

@@             Coverage Diff             @@
##             main    #8637       +/-   ##
===========================================
+ Coverage   60.47%   86.50%   +26.03%     
===========================================
  Files          12       87       +75     
  Lines        1513     8672     +7159     
  Branches       87     1110     +1023     
===========================================
+ Hits          915     7502     +6587     
- Misses        597     1128      +531     
- Partials        1       42       +41     
Flag Coverage Δ
builders 100.00% <ø> (?)
collection 100.00% <ø> (?)
proxy 74.10% <ø> (?)
rest 91.99% <ø> (?)
utilities 100.00% <ø> (?)
voice 63.86% <ø> (?)
ws 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ders/src/components/selectMenu/SelectMenuOption.ts 100.00% <0.00%> (ø)
...ges/builders/src/components/textInput/TextInput.ts 100.00% <0.00%> (ø)
packages/builders/src/components/Assertions.ts 100.00% <0.00%> (ø)
...ApplicationCommandNumericOptionMinMaxValueMixin.ts 100.00% <0.00%> (ø)
...ers/src/interactions/slashCommands/options/role.ts 100.00% <0.00%> (ø)
packages/builders/src/util/validation.ts 100.00% <0.00%> (ø)
packages/builders/src/interactions/modals/Modal.ts 100.00% <0.00%> (ø)
packages/rest/src/lib/REST.ts 98.87% <0.00%> (ø)
packages/voice/src/audio/AudioPlayer.ts 80.95% <0.00%> (ø)
packages/rest/src/lib/errors/HTTPError.ts 100.00% <0.00%> (ø)
... and 65 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel vercel bot temporarily deployed to Preview September 21, 2022 21:57 Inactive
@kodiakhq kodiakhq bot merged commit abb7226 into discordjs:main Sep 21, 2022
@almeidx almeidx deleted the discord.js/edit-channel-flags branch September 21, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants