Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct applied tags type #8641

Merged
merged 3 commits into from Sep 19, 2022
Merged

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Sep 19, 2022

Please describe the changes this PR makes and why it should be merged:
This required a full object, but only the ids are necessary.

In addition:

  • The return type is corrected on the helper method
  • ThreadEditData now possesses this property
  • The return type of the method in the typings no longer possibly returns a private thread

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Sep 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Sep 19, 2022 at 9:00PM (UTC)

@jaw0r3k
Copy link
Contributor

jaw0r3k commented Sep 19, 2022

maybe it could accept Tag or id ( like resolver )

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #8641 (25d41d8) into main (c446a84) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 25d41d8 differs from pull request most recent head 16f8e3b. Consider uploading reports for the commit 16f8e3b to get more accurate results

@@            Coverage Diff             @@
##             main    #8641      +/-   ##
==========================================
+ Coverage   86.66%   86.68%   +0.01%     
==========================================
  Files          86       87       +1     
  Lines        8771     8784      +13     
  Branches     1105     1110       +5     
==========================================
+ Hits         7601     7614      +13     
  Misses       1128     1128              
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 74.10% <ø> (ø)
rest 91.99% <ø> (ø)
utilities 100.00% <ø> (?)
voice 63.86% <ø> (ø)
ws 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/actions/src/formatTag/formatTag.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel vercel bot temporarily deployed to Preview September 19, 2022 21:00 Inactive
@kodiakhq kodiakhq bot merged commit f6f15d8 into discordjs:main Sep 19, 2022
@Jiralite Jiralite deleted the types/applied-tags branch September 19, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants