Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Correctly overwrite setRTCRegion method #8642

Merged
merged 3 commits into from Sep 19, 2022

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
The existing overwriting documentation for setRTCRegion() in voice channels and stage channels did not work. This pull request fixes them to correctly overwrite.

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Sep 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Sep 19, 2022 at 9:03PM (UTC)

Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classic

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #8642 (34420a8) into main (c446a84) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 34420a8 differs from pull request most recent head 10430b6. Consider uploading reports for the commit 10430b6 to get more accurate results

@@            Coverage Diff             @@
##             main    #8642      +/-   ##
==========================================
+ Coverage   86.66%   86.68%   +0.01%     
==========================================
  Files          86       87       +1     
  Lines        8771     8784      +13     
  Branches     1105     1110       +5     
==========================================
+ Hits         7601     7614      +13     
  Misses       1128     1128              
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 74.10% <ø> (ø)
rest 91.99% <ø> (ø)
utilities 100.00% <ø> (?)
voice 63.86% <ø> (ø)
ws 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/actions/src/formatTag/formatTag.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit f049734 into discordjs:main Sep 19, 2022
@Jiralite Jiralite deleted the docs/voice-rtc-documentation branch September 19, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants