Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow forum channels in webhook update event #8646

Merged
merged 1 commit into from Sep 20, 2022

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
I'm receiving forum channels in Client#webhookUpdate. Makes sense, as forum channels can have webhooks.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Sep 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Sep 20, 2022 at 10:08AM (UTC)

@Jiralite Jiralite changed the title feat:Alllow forum channels in webhook update event feat: Alllow forum channels in webhook update event Sep 20, 2022
@Jiralite Jiralite added this to the discord.js v14.4 milestone Sep 20, 2022
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #8646 (5a94159) into main (c446a84) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8646      +/-   ##
==========================================
+ Coverage   86.66%   86.68%   +0.01%     
==========================================
  Files          86       87       +1     
  Lines        8771     8784      +13     
  Branches     1105     1110       +5     
==========================================
+ Hits         7601     7614      +13     
  Misses       1128     1128              
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 74.10% <ø> (ø)
rest 91.99% <ø> (ø)
utilities 100.00% <ø> (?)
voice 63.86% <ø> (ø)
ws 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/actions/src/formatTag/formatTag.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kyranet kyranet changed the title feat: Alllow forum channels in webhook update event feat: Allow forum channels in webhook update event Sep 20, 2022
@kodiakhq kodiakhq bot merged commit 5048a3d into discordjs:main Sep 20, 2022
@Jiralite Jiralite deleted the feat/webhook-update-forum branch September 20, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants