Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow adding forums to channelTypes #8658

Merged
merged 2 commits into from Sep 24, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Sep 21, 2022

Please describe the changes this PR makes and why it should be merged:
Allows adding GuildForum channels to channel options

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Sep 24, 2022 at 1:36PM (UTC)

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #8658 (fa43404) into main (c446a84) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head fa43404 differs from pull request most recent head dfe1ba6. Consider uploading reports for the commit dfe1ba6 to get more accurate results

@@            Coverage Diff             @@
##             main    #8658      +/-   ##
==========================================
+ Coverage   86.66%   86.68%   +0.02%     
==========================================
  Files          86       87       +1     
  Lines        8771     8785      +14     
  Branches     1105     1110       +5     
==========================================
+ Hits         7601     7615      +14     
  Misses       1128     1128              
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <100.00%> (ø)
collection 100.00% <ø> (ø)
proxy 74.10% <ø> (ø)
rest 91.99% <ø> (ø)
utilities 100.00% <ø> (?)
voice 63.86% <ø> (ø)
ws 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ixins/ApplicationCommandOptionChannelTypesMixin.ts 100.00% <100.00%> (ø)
packages/actions/src/formatTag/formatTag.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel vercel bot temporarily deployed to Preview September 24, 2022 13:36 Inactive
@kodiakhq kodiakhq bot merged commit b1e190c into discordjs:main Sep 24, 2022
@almeidx almeidx deleted the builders/allowed-channels branch September 24, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants