Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ForumChannel): Implement missing properties and methods #8662

Merged
merged 4 commits into from Sep 24, 2022

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Resolves #8654 by implementing the missing properties and methods.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Sep 24, 2022 at 2:21PM (UTC)

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #8662 (5dee35e) into main (c446a84) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 5dee35e differs from pull request most recent head 3443ef8. Consider uploading reports for the commit 3443ef8 to get more accurate results

@@            Coverage Diff             @@
##             main    #8662      +/-   ##
==========================================
+ Coverage   86.66%   86.68%   +0.01%     
==========================================
  Files          86       87       +1     
  Lines        8771     8784      +13     
  Branches     1105     1110       +5     
==========================================
+ Hits         7601     7614      +13     
  Misses       1128     1128              
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 74.10% <ø> (ø)
rest 91.99% <ø> (ø)
utilities 100.00% <ø> (?)
voice 63.86% <ø> (ø)
ws 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/actions/src/formatTag/formatTag.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

RedGuy12 added a commit to scratchaddons-community/scradd that referenced this pull request Sep 23, 2022
waiting on discordjs/discord.js#8662 and a builders release before merge

This reverts commit ed1a413.

Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
RedGuy12 added a commit to scratchaddons-community/scradd that referenced this pull request Sep 23, 2022
waiting on discordjs/discord.js#8662 and a builders release before merge

This reverts commit ed1a413.

Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@kodiakhq kodiakhq bot merged commit 8622939 into discordjs:main Sep 24, 2022
@Jiralite Jiralite deleted the fix/forum-channel-missing branch September 24, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ForumChannel is missing some methods and properties
5 participants