Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RepliableInteraction respect cached generic #8667

Conversation

MaksiRose
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Fix #8652

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Sep 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Sep 24, 2022 at 2:02PM (UTC)

@vercel vercel bot temporarily deployed to Preview September 22, 2022 06:02 Inactive
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #8667 (c0f01a2) into main (c446a84) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head c0f01a2 differs from pull request most recent head 1ca3270. Consider uploading reports for the commit 1ca3270 to get more accurate results

@@            Coverage Diff             @@
##             main    #8667      +/-   ##
==========================================
+ Coverage   86.66%   86.78%   +0.12%     
==========================================
  Files          86       85       -1     
  Lines        8771     8772       +1     
  Branches     1105     1109       +4     
==========================================
+ Hits         7601     7613      +12     
+ Misses       1128     1117      -11     
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 80.46% <ø> (+6.36%) ⬆️
rest 91.99% <ø> (ø)
utilities 100.00% <ø> (?)
voice 63.83% <ø> (-0.04%) ⬇️
ws 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/voice/src/util/util.ts
packages/proxy/src/util/util.ts
packages/actions/src/formatTag/formatTag.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@kodiakhq kodiakhq bot merged commit 578bc95 into discordjs:main Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

RepliableInteraction type doesn't respect Cached generic
5 participants