Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ThreadChannel): Allow editing flags #8671

Merged
merged 2 commits into from Sep 24, 2022

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Allowing threads to edit flags which was overlooked in #8637.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Sep 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Sep 24, 2022 at 1:55PM (UTC)

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #8671 (bd90a08) into main (b1e190c) will decrease coverage by 13.21%.
The diff coverage is n/a.

❗ Current head bd90a08 differs from pull request most recent head dd3defc. Consider uploading reports for the commit dd3defc to get more accurate results

@@             Coverage Diff              @@
##              main    #8671       +/-   ##
============================================
- Coverage   100.00%   86.78%   -13.22%     
============================================
  Files           39       85       +46     
  Lines         3200     8772     +5572     
  Branches       410     1109      +699     
============================================
+ Hits          3200     7613     +4413     
- Misses           0     1117     +1117     
- Partials         0       42       +42     
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (?)
proxy 80.46% <ø> (?)
rest 91.99% <ø> (?)
utilities 100.00% <ø> (?)
voice 63.83% <ø> (?)
ws 60.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ixins/ApplicationCommandOptionChannelTypesMixin.ts 100.00% <0.00%> (ø)
packages/voice/src/joinVoiceChannel.ts 100.00% <0.00%> (ø)
packages/voice/src/receive/SpeakingMap.ts 100.00% <0.00%> (ø)
...src/strategies/context/IContextFetchingStrategy.ts 100.00% <0.00%> (ø)
packages/voice/src/util/entersState.ts 100.00% <0.00%> (ø)
packages/ws/src/utils/IdentifyThrottler.ts 100.00% <0.00%> (ø)
packages/voice/src/VoiceConnection.ts 81.76% <0.00%> (ø)
packages/voice/src/networking/VoiceUDPSocket.ts 90.47% <0.00%> (ø)
.../src/strategies/sharding/WorkerShardingStrategy.ts 95.87% <0.00%> (ø)
packages/voice/src/networking/VoiceWebSocket.ts 0.00% <0.00%> (ø)
... and 37 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 1244854 into discordjs:main Sep 24, 2022
@Jiralite Jiralite deleted the fix/thread-edit-flags branch September 24, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants