Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix events augmentation #8681

Merged
merged 2 commits into from Oct 10, 2022

Conversation

MrMythicalYT
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This PR fixes the module augmentation for node:events

Fixes #8634
Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Sep 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Sep 26, 2022 at 1:42AM (UTC)

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #8681 (e1a8e75) into main (3c231ae) will decrease coverage by 5.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8681      +/-   ##
==========================================
- Coverage   92.08%   86.82%   -5.27%     
==========================================
  Files          10       85      +75     
  Lines        2098     8797    +6699     
  Branches      240     1113     +873     
==========================================
+ Hits         1932     7638    +5706     
- Misses        163     1117     +954     
- Partials        3       42      +39     
Flag Coverage Δ
builders 100.00% <ø> (?)
collection 100.00% <ø> (?)
proxy 80.46% <ø> (?)
rest 92.08% <ø> (ø)
utilities 100.00% <ø> (?)
voice 63.83% <ø> (?)
ws 60.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/interactions/slashCommands/options/integer.ts 100.00% <0.00%> (ø)
...es/builders/src/components/textInput/Assertions.ts 100.00% <0.00%> (ø)
packages/voice/src/networking/Networking.ts 3.18% <0.00%> (ø)
packages/builders/src/components/ActionRow.ts 100.00% <0.00%> (ø)
...eractions/slashCommands/SlashCommandSubcommands.ts 100.00% <0.00%> (ø)
.../src/interactions/slashCommands/options/boolean.ts 100.00% <0.00%> (ø)
.../src/strategies/sharding/SimpleShardingStrategy.ts 78.20% <0.00%> (ø)
...ackages/voice/src/util/generateDependencyReport.ts 0.00% <0.00%> (ø)
...src/interactions/contextMenuCommands/Assertions.ts 100.00% <0.00%> (ø)
packages/voice/src/joinVoiceChannel.ts 100.00% <0.00%> (ø)
... and 65 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iCrawl iCrawl merged commit ac83ada into discordjs:main Oct 10, 2022
@MrMythicalYT MrMythicalYT deleted the types/events-augmentation branch October 10, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

types: overriding events.once type causes bad intellisense autocompletion elsewhere
3 participants