Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(ModalBuilder): fix constructor typings #8690

Merged

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Sep 30, 2022

Please describe the changes this PR makes and why it should be merged:
Fixes #8468

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Sep 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Oct 1, 2022 at 1:47PM (UTC)

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #8690 (f6e13cd) into main (c69f512) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head f6e13cd differs from pull request most recent head 5ff866b. Consider uploading reports for the commit 5ff866b to get more accurate results

@@            Coverage Diff             @@
##             main    #8690      +/-   ##
==========================================
+ Coverage   86.79%   86.82%   +0.03%     
==========================================
  Files          85       85              
  Lines        8777     8797      +20     
  Branches     1109     1113       +4     
==========================================
+ Hits         7618     7638      +20     
  Misses       1117     1117              
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 80.46% <ø> (ø)
rest 92.08% <100.00%> (+0.07%) ⬆️
utilities 100.00% <ø> (ø)
voice 63.83% <ø> (ø)
ws 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/rest/src/lib/RequestManager.ts 90.34% <100.00%> (+0.09%) ⬆️
...ackages/rest/src/lib/handlers/SequentialHandler.ts 86.44% <100.00%> (+0.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 2ea2a85 into discordjs:main Oct 1, 2022
@almeidx almeidx deleted the discord.js/modal-builder-constructor-type branch October 1, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Incorrect types for the ModalBuilder constructor
5 participants