Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Util): backport escapeMarkdown PRs to v13 #8703

Merged
merged 4 commits into from Oct 10, 2022
Merged

feat(Util): backport escapeMarkdown PRs to v13 #8703

merged 4 commits into from Oct 10, 2022

Conversation

RedGuy12
Copy link
Contributor

@RedGuy12 RedGuy12 commented Oct 4, 2022

Please describe the changes this PR makes and why it should be merged:
Backports #7587, #7638, and #8701 to v13
Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes potentially breaking changes (methods removed or renamed, parameters moved or removed) (see feat(Util): escape more markdown characters #8701)

@RedGuy12
feat(Util): backport escapeMarkdown PRs to v13
cda0cca 
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@Jiralite Jiralite added this to the discord.js v13.12 milestone Oct 4, 2022
vladfrangu
vladfrangu reviewed Oct 5, 2022
View reviewed changes
src/util/Util.js Outdated Show resolved Hide resolved
@RedGuy12
fix: lists bulleted with *
ffd878c 
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Oct 5, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ❌ Failed (Inspect) Oct 7, 2022 at 1:28PM (UTC)
discord-js-guide ❌ Failed (Inspect) Oct 7, 2022 at 1:28PM (UTC)

@vercel vercel bot temporarily deployed to Preview October 5, 2022 16:43 Inactive
@RedGuy12
tests(escapeMarkdown): add tests
d3c8592 
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview October 6, 2022 16:36 Inactive
@iCrawl iCrawl merged commit 8a6588a into discordjs:v13 Oct 10, 2022
@RedGuy12 RedGuy12 deleted the gh-8689-v13 branch October 10, 2022 20:47
@RedGuy12 RedGuy12 mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js v13.12
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RedGuy12 @vladfrangu @kyranet @iCrawl @Jiralite